From db5719847c9397bc96081ec805354a3dca61a1dd Mon Sep 17 00:00:00 2001 From: Tor Andersson Date: Sun, 10 Dec 2023 23:45:17 +0100 Subject: Only check front choice / rear choice asserts if using that choice. There may still be a potential problem lurking in strike_left_right or assign_left_right when both fc and rc are unset, and only fc is assigned... --- rules.js | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/rules.js b/rules.js index cb00bc0..5568525 100644 --- a/rules.js +++ b/rules.js @@ -8220,12 +8220,15 @@ function find_closest_target(A, B, C) { } function find_closest_target_center(T2) { - if (game.battle.fc < 0) throw Error("unset front l/r choice") - if (game.battle.rc < 0) throw Error("unset rear l/r choice") if (filled(T2)) return T2 - if (T2 >= A1 && T2 <= D3) + if (T2 >= A1 && T2 <= D3) { + if (game.battle.fc < 0) + throw Error("unset front l/r choice") return game.battle.fc + } + if (game.battle.rc < 0) + throw Error("unset rear l/r choice") return game.battle.rc } -- cgit v1.2.3